Add gender symbol option to the detailed ancestral report #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-Hall
changed the title
|
The get_name method in the relationship view uses Otherwise I like this PR. |
|
Thanks. I will push the new code in real soon.
PS: If I push the new remediation changes in the next couple of days, is
there any chance this feature can make it to the next gramps 6.0 release?
…On Mon, Jan 13, 2025, 1:05 PM Nick Hall ***@***.***> wrote:
The get_name
<https://github.com/gramps-project/gramps/blob/master/gramps/plugins/view/relview.py#L607>
method in the relationship view uses
self.symbols.get_symbol_for_string(person.gender) to get the gender
symbol. Only the values 0, 1, 2 and 3 are allowed in the gender field of a
person. Your _MSYM_GSET variable is not necessary.
Otherwise I like this PR.
—
Reply to this email directly, view it on GitHub
<#1818 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2TV3PAVTU2SSZ6Q5KMCMT2KQFBDAVCNFSM6AAAAABTGNKLC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBXHE3DQMZZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yes. The PR was submitted before the cut-off. |
|
Remove unnecessary _MSYM_GSET. |
Nick-Hall
force-pushed
the
NewFeatureDetAncestralReport
branch
from
891b136 to
fa3c2c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to insert a gender symbol before the person's name